On 11/24/14 12:07, Pavel Hrdina wrote: > The vram attribute was introduced to set the video memory but it is > usable only for few hypervisors excluding QEMU/KVM and the old XEN > driver. Only in case of QEMU the vram was used for QXL. > > This patch updates the documentation to reflect current code in libvirt > and also changes the cases when we will set the default vram attribute. > It also fixes existing strange default value for VGA devices 9MB to 16MB > because the video ram should be rounded to power of two.
Indeed. Except for QXL we don't pass the value to qemu or others ... > > The change of default value could affect migrations but I found out that > QEMU always round the video ram to power of two internally so it's safe > to change the default value to the next closest power of two and also > silently correct every domain XML definition. And it's also safe because > we don't pass the value to QEMU. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1076098 > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > docs/formatdomain.html.in | 66 > ++++++++++++++-------- > src/conf/domain_conf.c | 15 +++-- > src/conf/domain_conf.h | 3 +- > src/qemu/qemu_command.c | 16 ++++-- > src/xen/xen_driver.c | 2 +- ... > tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml | 2 +- > tests/virt-aa-helper-test | 2 +- > 43 files changed, 103 insertions(+), 75 deletions(-) > ACK. Peter
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
