On Mon, Dec 08, 2014 at 03:12:11PM +0000, Daniel P. Berrange wrote:
On Mon, Dec 08, 2014 at 04:07:39PM +0100, Peter Krempa wrote:On 12/05/14 15:02, Martin Kletzander wrote: > Currently, when there is an API that's blocking with locked domain and > second API that's waiting in virDomainObjListFindByUUID() for the domain > lock (with the domain list locked) no other API can be executed on any > domain on the whole hypervisor because all would wait for the domain > list to be locked. This patch adds new optional approach to this in > which the domain is only ref'd (reference counter is incremented) > instead of being locked and is locked *after* the list itself is > unlocked. We might consider only ref'ing the domain in the future and > leaving locking on particular APIs, but that's no tonight's fairy tale. > > Signed-off-by: Martin Kletzander <mklet...@redhat.com> > --- > src/conf/domain_conf.c | 27 ++++++++++++++++++++++++--- > src/conf/domain_conf.h | 2 ++ > src/libvirt_private.syms | 1 + > 3 files changed, 27 insertions(+), 3 deletions(-) >ACK, although given that the devel freeze is tomorrow and second patch of this series is pretty invasive, I think that giving this change a full dev cycle is a better way to go.Agreed, particularly as this will be a longer dev cycle than usual due to christmas - don't want to risk destablising this release.
Definitely, I wouldn't feel very safe this close to release :) I'll push it after 1.2.11 then. Thank you for the review,
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
