On 12/15/2014 08:33 AM, Daniel P. Berrange wrote: > In systemd >= 218, the udev_set_log_fn method has been marked > deprecated and turned into a no-op. Nothing in the udev client > library will print to stderr by default anymore, so we can > just stop installing a logging hook for new enough udev. > --- > m4/virt-udev.m4 | 7 +++++++ > src/node_device/node_device_udev.c | 5 ++++- > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/m4/virt-udev.m4 b/m4/virt-udev.m4 > index 55673bf..0d785c4 100644 > --- a/m4/virt-udev.m4 > +++ b/m4/virt-udev.m4 > @@ -24,6 +24,13 @@ AC_DEFUN([LIBVIRT_CHECK_UDEV],[ > if test "$with_udev" = "yes" && test "$with_pciaccess" != "yes" ; then > AC_MSG_ERROR([You must install the pciaccess module to build with udev]) > fi > + > + if test "$with_udev" = "yes" ; then > + PKG_CHECK_EXISTS(libudev >= 218, [with_udev_logging=no], > [with_udev_logging=yes])
Style: I'd write [libudev >= 218] (that is, add [] quoting), since autoconf recommends quoting all arguments. ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
