On Thu, Jan 08, 2015 at 15:48:16 +0000, Daniel Berrange wrote: > The phyp driver is passing the VIR_DOMAIN_XML_SECURE flag to > virDomainDefParseString which is wrong, because that flag only > has effect when formatting XML. > --- > src/phyp/phyp_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c > index 269d030..71db7bd 100644 > --- a/src/phyp/phyp_driver.c > +++ b/src/phyp/phyp_driver.c > @@ -3558,7 +3558,7 @@ phypDomainCreateXML(virConnectPtr conn, > if (!(def = virDomainDefParseString(xml, phyp_driver->caps, > phyp_driver->xmlopt, > 1 << VIR_DOMAIN_VIRT_PHYP, > - VIR_DOMAIN_XML_SECURE))) > + 0))) > goto err; > > /* checking if this name already exists on this system */
ACK, I think this could be just squashed in to the previous patch. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
