On 02/03/2015 08:54 AM, Daniel P. Berrange wrote: > It is often helpful to know which version of libvirt and QEMU > was present when a guest was first launched. Ensure this info > is written into the QEMU log file for each guest. > --- > src/qemu/qemu_capabilities.c | 22 +++++++++++++++++- > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 2 +- > src/qemu/qemu_process.c | 54 > ++++++++++++++++++++++++++++++++------------ > src/util/virlog.c | 17 ++------------ > src/util/virlog.h | 13 +++++++++++ > 6 files changed, 77 insertions(+), 32 deletions(-) >
> +++ b/src/qemu/qemu_command.c
> @@ -7988,7 +7988,7 @@ qemuBuildCommandLine(virConnectPtr conn,
> if (def->mem.nhugepages && (!def->cpu || !def->cpu->ncells)) {
> const long system_page_size = sysconf(_SC_PAGESIZE) / 1024;
> char *mem_path = NULL;
> -
> + fprintf(stderr, "SYSCONF %ld\n", system_page_size);
Spurious hunk.
> +static void qemuLogOperation(virDomainObjPtr vm,
Worth splitting to two lines?
ACK with those fixes.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
