"Daniel P. Berrange" <berra...@redhat.com> wrote: > On Wed, Jan 14, 2009 at 02:29:14PM +0100, Jim Meyering wrote: >> "Daniel P. Berrange" <berra...@redhat.com> wrote: >> ... >> > No, they are all correct AFAIK. The *existing* code was buggy using >> > the wrong macros in many places. >> ... >> > You need to compare with the function context shown in the patch, rather >> > than assume the original code was correct :-) >> >> Yeah, "assuming" can cause trouble ;-) >> >> It would help others down the road if there were a note >> in the ChangeLog that this change set also fixes several bugs. > > I comitted this in two parts, the first doing the bug fix.
Thanks! FYI, I've rebased the git tree. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
