On 05/13/2015 10:58 AM, Eric Blake wrote: > On 05/13/2015 04:55 AM, Ján Tomko wrote: >>>> Okay, I see your counterargument. Still, strstr() is pretty expensive >>>> compared to just: >>>> >>>> if (def->bridge && >>>> (p = strchr(def->bridge, '%')) == strrchr(def->bridge, '%') && >>>> p[1] == 'd') >>>> >>> >>> Coverity complains : >>> >>> Event returned_null: "strchr" returns null (checked 273 out of 288 >>> times). >> >> strchr does not return NULL here because networkFindUnusedBridgeName is >> only called if either def->bridge is NULL or def->bridge contains "%d". > > Adding "p &&" just before "p[1] == 'd'" should silence the false > positive, right? >
Yes. I'll send something in a bit - there's another two that are queued up as well. John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
