On Mon, Jul 06, 2015 at 13:08:33 -0400, John Ferlan wrote: > Refactor the functions to follow logic from qemuAddSharedDisk and > qemuRemoveSharedDisk with respect to locking driver. > > Signed-off-by: John Ferlan <jfer...@redhat.com> > --- > src/qemu/qemu_conf.c | 27 ++++++++++++++++++--------- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > index eb0b34f..8afbddc 100644 > --- a/src/qemu/qemu_conf.c > +++ b/src/qemu/qemu_conf.c > @@ -1291,13 +1291,18 @@ qemuAddSharedHostdev(virQEMUDriverPtr driver, > if (!qemuIsSharedHostdev(hostdev)) > return 0; > > + qemuDriverLock(driver); > + > if (!(key = qemuGetSharedHostdevKey(hostdev)))
This function doesn't need necessarily be called from the critical section so I don't see a reason to carry this patch. Peter
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
