On Mon, 2015-08-03 at 15:13 +0200, Peter Krempa wrote: > > > Looks okay overall and works as expected from my limited > > testing on ppc64. > > > > One thing, though: the domain XML is not updated with the > > rounded-up value, which I think might be a little bit > > confusing to the user. Any chance the rounding up could > > be reflected there as well? > > The rounding will be reflected once you start the VM in the live XML. > This is also the case with the 1MiB rounding that is currently used, > but > it's not as prominent as the 256MiB granularity.
Let's file updating the on-disk XML under "would be nice to have" then. ACK series. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
