On 08/27/2015 05:54 AM, John Ferlan wrote:
On 08/13/2015 10:15 AM, Luyao Huang wrote:
First review:
http://www.redhat.com/archives/libvir-list/2015-July/msg00982.html
Change in v2:
- split it to two patches
- fix some small mistake in hot-unplug part
I change the code in qemuDomainAttachMemory like what we do in other attach
deivce
functions. And I have removed the jump in qemuDomainRemoveMemoryDevice, since i
just
see only one place need jump to audit, so i refactor the code (thanks John's
advise).
Luyao Huang (2):
qemu: fix the audit log is not correct after hot-plug memory success
qemu: fix the audit log is not correct after hot-unplug memory device
src/qemu/qemu_hotplug.c | 35 +++++++++++++++++------------------
1 file changed, 17 insertions(+), 18 deletions(-)
These look much cleaner code wise - had to clean up the commit messages,
but otherwise fine. I have pushed the two patches.
Thanks a lot for your review and help.
John
Luyao
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
