Hi, >> + guint settime_flags; >> + >> + g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE); >> + g_return_val_if_fail(err == NULL || *err == NULL, FALSE); > > I'd keep a g_return_val_if_fail(flags == 0, FALSE);
But doesn't that make G_GNUC_UNUSED declaration wrong then? I think it's more important to optimize it out rather than ensuring programmer doesn't pass wrong value by mistake, here. -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
