On 02/15/2016 05:31 PM, Laine Stump wrote: > On 02/15/2016 02:37 PM, John Ferlan wrote: >> Move the misplaced function from qemu_command.c to qemu_interface.c >> since it's closer in functionality there and had less to do with building >> the command line. >> >> Rename function to qemuInterfacePhysicalConnect and modify callers. >> >> Signed-off-by: John Ferlan <jfer...@redhat.com> >> --- > > Yay! Moving this (and qemuNetworkIfaceConnect()) to a separate file was > the reason behind me requesting that qemu_interface.c be created for > commit 82977058. I just never followed up and did it. > > I would suggest that this function be called > qemuInterfaceDirectConnect() though - that matches with the name used > for macvtap/macvlan connections in libvirt's xml config. >
Done. > >> --- a/src/qemu/qemu_interface.c >> +++ b/src/qemu/qemu_interface.c >> @@ -1,6 +1,7 @@ >> /* >> * qemu_interface.c: QEMU interface management >> * >> + * Copyright (C) 2015-2016 Red Hat, Inc. > > If you're going to transfer copyright over from qemu_command.c to here, > you should probably do it for the full range of the old file - 2006-2016. > >> * Copyright IBM Corp. 2014 >> * >> * This library is free software; you can redistribute it and/or > >> +} >> diff --git a/src/qemu/qemu_interface.h b/src/qemu/qemu_interface.h >> index b4c1efc..aa2791e 100644 >> --- a/src/qemu/qemu_interface.h >> +++ b/src/qemu/qemu_interface.h >> @@ -1,6 +1,7 @@ >> /* >> * qemu_interface.h: QEMU interface management >> * >> + * Copyright (C) 2014, 2016 Red Hat, Inc. > > Same here. > > ACK with the copyright changes and rename of the function. > > I was working under the assumption that the modules were created in 2014 with the .c changing in 2015, but the .h not changing there. I'll change it as suggested unless someone else has better advice... Thanks - for the quick look on the Interface functions! John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
