----- Original Message -----
> From: "John Ferlan" <jfer...@redhat.com>
> To: "Paolo Bonzini" <pbonz...@redhat.com>, libvir-list@redhat.com
> Sent: Monday, February 22, 2016 3:00:19 PM
> Subject: Re: [libvirt] [PATCH] qemu: add support for LSI SAS1068 (aka MPT 
> Fusion) SCSI controller
> 
> 
> 
> On 02/11/2016 05:48 AM, Paolo Bonzini wrote:
> > This does nothing more than adding the new device and capability.
> > The device is present since QEMU 2.6.0.
> > 
> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> > ---
> >  src/qemu/qemu_capabilities.c                       |  2 +
> >  src/qemu/qemu_capabilities.h                       |  1 +
> >  src/qemu/qemu_command.c                            | 13 ++++++-
> >  .../qemuxml2argv-disk-scsi-mptsas1068.args         | 27 +++++++++++++
> >  .../qemuxml2argv-disk-scsi-mptsas1068.xml          | 36 ++++++++++++++++++
> >  tests/qemuxml2argvtest.c                           |  4 ++
> >  .../qemuxml2xmlout-disk-scsi-mptsas1068.xml        | 44
> >  ++++++++++++++++++++++
> >  tests/qemuxml2xmltest.c                            |  4 ++
> >  8 files changed, 130 insertions(+), 1 deletion(-)
> >  create mode 100644
> >  tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-mptsas1068.args
> >  create mode 100644
> >  tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-mptsas1068.xml
> >  create mode 100644
> >  tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-mptsas1068.xml
> > 
> 
> Is the '<wwn>' required to be provided for the <disk> XML if using this
> controller?

No, but on Linux the disks are only visible if you have a WWN, so I
chose to include it in the tests.

Paolo

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to