On Tue, Feb 23, 2016 at 09:49:09AM +0100, Michal Privoznik wrote: > There's this check when building command line that whenever > domain has no graphics card configured we put -nographics onto > qemu command line. The check is 'if (!def->graphics)'. This > makes coverity think that def->graphics can be NULL, which is > true. But later in the code every access to def->graphics is > guarded by check for def->ngraphics, so no crash occurs. But this > is something that coverity fails to deduct. > In order to shut coverity up lets change the condition to > 'if (!def->ngraphics)'. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > --- > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
ACK > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index 78423e7..854e51c 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -7130,7 +7130,7 @@ qemuBuildCommandLine(virConnectPtr conn, > * if you ask for nographic. So we have to make sure we override > * these defaults ourselves... > */ > - if (!def->graphics) { > + if (!def->ngraphics) { For integers, I have a slight preference for == 0, but this seems to be the prevailing style in qemuBuildCommandLine. Jan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list