On Fri, Mar 18, 2016 at 10:28:10AM +0100, Ján Tomko wrote: > > @@ -7234,7 +7234,14 @@ > > qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, > > virBufferTrim(&opt, ",", -1); > > > > virCommandAddArg(cmd, "-spice"); > > - virCommandAddArgBuffer(cmd, &opt); > > + /* If we did not add any SPICE arguments, add a dummy 'port=0' one > > + * as -spice alone is not allowed on QEMU command line and will be > > + * ignored by libvirt > > I am confused by the "will be ignored by libvirt" part.
I'm confused too :) I'll drop this before pushing. Maybe I meant that 'port=0' is now ignored (not added) by libvirt, so we may end up with an empty -spice parameter list, so we need to make sure it's not empty. Better to drop this. Christophe
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
