On Fri, Apr 08, 2016 at 06:04:51PM +0200, Andrea Bolognani wrote:
virt-host-validate, just like virt-login-shell, doesn't make sense on Windows, so we should avoid building it.Make the tool optional and build it by default on all platforms except Windows, erroring out if the user attempts to build it anyway. --- configure.ac | 29 ++++++++++++++++++----------- m4/virt-host-validate.m4 | 40 ++++++++++++++++++++++++++++++++++++++++ tools/Makefile.am | 9 ++++++++- 3 files changed, 66 insertions(+), 12 deletions(-) create mode 100644 m4/virt-host-validate.m4
[...]
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 930e6c3..16a1aed 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -64,7 +64,7 @@ confdir = $(sysconfdir)/libvirt
conf_DATA =
bin_SCRIPTS = virt-xml-validate virt-pki-validate
-bin_PROGRAMS = virsh virt-host-validate virt-admin
+bin_PROGRAMS = virsh virt-admin
libexec_SCRIPTS = libvirt-guests.sh
dist_man1_MANS = \
virt-host-validate.1 \
@@ -89,6 +89,13 @@ EXTRA_DIST += \
virt-login-shell.1
endif ! WITH_LOGIN_SHELL
+if WITH_HOST_VALIDATE
+bin_PROGRAMS += virt-host-validate
+dist_man1_MANS += virt-host-validate.1
+else ! WITH_HOST_VALIDATE
+EXTRA_DIST += virt-host-validate.1
+endif ! WITH_HOST_VALIDATE
+
I haven't looked that much into it, but I don't think we should put the generated man pages into the dist, but rather the .pod files and that are there by default, right? Could just removing the: EXTRA_DIST += virt-host-validate.1 be enough to fix what Cole saw happen?
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
