On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote:
> Reports a tristate enum value for acceptable graphics type=spice
> <gl enable=XXX/>.
>
> Wire it up for qemu too. 'no' is always a valid value, so we
> unconditionally report it.
> ---
[...]
> diff --git a/tests/domaincapsschemadata/domaincaps-full.xml
> b/tests/domaincapsschemadata/domaincaps-full.xml
> index 2f529ff..4eb5637 100644
> --- a/tests/domaincapsschemadata/domaincaps-full.xml
> +++ b/tests/domaincapsschemadata/domaincaps-full.xml
> @@ -47,6 +47,11 @@
> <value>desktop</value>
> <value>spice</value>
> </enum>
> + <enum name='spiceGL'>
> + <value>default</value>
> + <value>yes</value>
> + <value>no</value>
> + </enum>
Ewww, this doesn't look good and I agree with Michal that what if we add
support for another graphics device and what if one graphics device will have
more than one capability?
I would suggest something like this:
<graphics supported='yes'>
<enum name='type'>
<value>spice</value>
<value>vnc</value>
<value>sdl</value>
</enum>
<type name='spice'>
<gl supported='yes'/>
</type>
</graphics>
or even do something like this:
<graphics supported='yes'>
<type name='spice'>
<gl supported='yes'/>
</type>
<type name='vnc'/>
<type name='sdl'/>
</graphics>
Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
