On Wed, May 25, 2016 at 4:06 PM, Pavel Hrdina <phrd...@redhat.com> wrote:
> On Wed, May 25, 2016 at 03:49:04AM -0500, Shivaprasad G Bhat wrote:
> > Signed-off-by: Shivaprasad G Bhat <sb...@linux.vnet.ibm.com>
> > ---
> > src/qemu/qemu_driver.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index 249393a..3f26f1f 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -8237,7 +8237,7 @@ qemuDomainAttachDeviceFlags(virDomainPtr dom,
> > if (priv->qemuCaps)
> > qemuCaps = virObjectRef(priv->qemuCaps);
> > else if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache,
> vm->def->emulator)))
> > - goto cleanup;
> > + goto endjob;
> >
> > if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
> > /* Make a copy for updated domain. */
> > @@ -8490,7 +8490,7 @@ qemuDomainDetachDeviceFlags(virDomainPtr dom,
> > if (priv->qemuCaps)
> > qemuCaps = virObjectRef(priv->qemuCaps);
> > else if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache,
> vm->def->emulator)))
> > - goto cleanup;
> > + goto endjob;
> >
> > if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
> > /* Make a copy for updated domain. */
>
> The same bug is also on line 8369, could you fix that too and send a v2?
>
>
Oh I see.. I scanned the whole file from AttachDeviceConfig() for this bug
if exists anywhere else. Not sure
how I missed UpdateDeviceConfig() though. :) Just sent the V2.
Thanks,
Shivaprasad
> Pavel
>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
