On Fri, Sep 16, 2016 at 03:06:27PM +0200, Tomáš Ryšavý wrote:
Because the file had over 7000 lines. Now its splitted into 5 smaller files. It looks clearer and it's better for reading the code.
Similar to that, this patch has over .5 MiB, it could've been split into multiple patches. Not only for easier review. Also, we tend to name our commits a bit differently. Rather use present tense than past tense (i.e. "Split file asdf.c" instead of "File asdf.c was split (also split, not splitted)). And don't end commit messages with a full stop, it just looks weird and takes space and, to me, looking at the logs it kinda stands out for no reason. I'm not saying NACK to this, but I'm not going to review it either when it looks like this. No hard feelings, though. Don't take that the wrong way ;) If someone does review this, though, then at least s/\.$// and s/splitted/split/ in $SUBJ. Martin
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
