On Wed, Jun 17, 2009 at 12:22:13PM -0700, David Lutterkort wrote:
> On Wed, 2009-06-17 at 19:24 +0100, Daniel P. Berrange wrote:
> > IP address information should be in the XML, and indeed surely it is 
> > already there in order to allow non-DHCP  based IP address config
> > on interfaces ?
> 
> Yes, for statically configured interfaces, the IP information is in the
> XML - that is the _configured_ IP info though, not necessarily the one
> that the interface actually uses. The two can diverge, for example, if
> an interface is already up and then reconfigured.

  BTW I was looking at the Relax-NG grammar and found the following
confusing when providing an IP address:

        <element name="ip">
          <optional>
            <attribute name="address"><ref name="ip-mask"/></attribute>
          </optional>
        </element>

I'm not really sure what ip-mask really means, are you trying to
put in a single attribute both the IP address and the netmask ?
If that's the case I would really suggest to split the two as separated
IP and netmask in the XML structure, either separate attributes or
another element for the netmask. Best to us the explicit structure of
XML than a construct hidden inside the text field, unless I
misunderstood the use case...

  Sorry for hijacking :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to