There are still some systems out there that have broken setfilecon*() prototypes. Instead of taking 'const char *tcon' it is taking 'char *tcon'. The function should just set the context, not modify it.
We had been bitten with this problem before which resulted in 292d3f2d and subsequently b109c09765. However, with one my latest commits (4674fc6afd6d) I've changed the type of @tcon variable to 'const char *' which results in build failure on the systems from above. Signed-off-by: Michal Privoznik <mpriv...@redhat.com> --- src/security/security_selinux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 92267e8fc..f229b5139 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -1138,7 +1138,7 @@ virSecuritySELinuxSetFileconHelper(const char *path, const char *tcon, VIR_INFO("Setting SELinux context on '%s' to '%s'", path, tcon); - if (setfilecon_raw(path, tcon) < 0) { + if (setfilecon_raw(path, (VIR_SELINUX_CTX_CONST char *) tcon) < 0) { int setfilecon_errno = errno; if (getfilecon_raw(path, &econ) >= 0) { -- 2.11.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list