On 04/20/2017 06:01 AM, Michal Privoznik wrote: > Ideally, this would be generated, but to achieve that > corresponding XDR definitions needed to go into a different .x > file. But they belong just to the one that they are right now.
I'm glad you understand what this commit message is hinting at... Because I have no idea which .x file is being called out. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > --- > tools/wireshark/src/packet-libvirt.c | 48 > ++++++++++++++++++++++++++++++++++++ > tools/wireshark/src/packet-libvirt.h | 2 ++ > 2 files changed, 50 insertions(+) > What's done seems reasonable, but this is certainly not an area of the code I've ever been through or thought about. Although I would think this would have to wait for any @flags argument at least to properly understand the packet. Weak ACK - John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
