On Thu, Jun 01, 2017 at 01:19:05PM +0100, Daniel P. Berrange wrote:
On Thu, Jun 01, 2017 at 02:08:34PM +0200, Martin Kletzander wrote:Users need to remove their callbacks before calling virStreamAbort() or virStreamFinish() even though that's not documented anywhere. Since it makes no sense to keep those callbacks, we can remove them when the stream is being aborted or finished. That way it is also more intuitive for developers as that removes some confusing errors being reported.This changes the semantics of a public API though, so even though the suggested behavious would be useful, we mustn't do this as it creates an API incompatability across versions.
I couldn't find any case that could be broken by this change. Do you have any in mind?
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
