On Wed, Aug 19, 2009 at 03:19:07PM +0200, Daniel Veillard wrote: > On Wed, Aug 19, 2009 at 05:36:27AM -0400, Miloslav Trmac wrote: > > ----- "Daniel Veillard" <veill...@redhat.com> wrote: > > > > > +virSecretPtr virSecretDefineXML (virConnectPtr conn, > > > > + const char *xml); > > > > > > Let's add an "unsigned int flags" to virSecretDefineXML() especially > > > as we don't know yet the scope of future usages. > > > > > > > +char * virSecretGetXMLDesc (virSecretPtr secret); > > > > > > And also add an "unsigned int flags" to virSecretGetXMLDesc > > > > > Will do. > > Actually I think virConnectListSecrets should get one too :-)
I think that's overkill - none of the other virConnectList* methods have them - we only do it for Define/Create/GetXML in other APIs. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
