On Mon, 2018-03-19 at 15:38 -0400, Cole Robinson wrote: > Yet another dependency on dict() hash ordering > > Signed-off-by: Cole Robinson <crobi...@redhat.com> > --- > src/hyperv/hyperv_wmi_generator.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/hyperv/hyperv_wmi_generator.py > b/src/hyperv/hyperv_wmi_generator.py > index d54810211..6582fe1f1 100755 > --- a/src/hyperv/hyperv_wmi_generator.py > +++ b/src/hyperv/hyperv_wmi_generator.py > @@ -271,7 +271,7 @@ class WmiClass: > > # isolate those that are common for all and keep track of their > postions > pos = 0 > - for key in property_info: > + for key in sorted(property_info): > info = property_info[key] > # exists in all class versions > if info[1] == num_classes:
Reviewed-by: Andrea Bolognani <abolo...@redhat.com> The order in which struct members appear is now different from what it was before but it's consistent between Python 2 and 3. Hopefully none of this matters in practice, but if anything broke because of it at least we're sure to get bug reports quickly :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
