On Wed, 2018-05-02 at 12:24 +0200, Andrea Bolognani wrote: > On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote: > > Fixes "can't find libtool" error when running valgrind checks. > > --- > > tests/Makefile.am | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/Makefile.am b/tests/Makefile.am > > index 7b93fbde6..05db6b119 100644 > > --- a/tests/Makefile.am > > +++ b/tests/Makefile.am > > @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full > > --trace-children=yes \ > > --trace-children-skip="*/tools/virsh","*/tests/commandhelper" \ > > --suppressions=$(srcdir)/.valgrind.supp > > valgrind: > > - $(MAKE) check VG="libtool --mode=execute $(VALGRIND)" > > + $(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)" > > > > sockettest_SOURCES = \ > > sockettest.c \ > > Reviewed-by: Andrea Bolognani <abolo...@redhat.com> > > We're in development freeze now, so I'll push this after release.
Sorry, I forgot to mention the fact that libvirt requires a Signed-off-by for all contributions these days... So you're going to have to provide that before I can push your patch. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
