[...]
>> + cleanup:
>> + if (ret < 0) {
>> + virErrorPreserveLast(&originalError);
>> + if (releaseaddr)
>> + qemuDomainReleaseDeviceAddress(vm, &vsock->info, NULL);
>> + virErrorRestore(&originalError);
>> + }
>> +
>> + virDomainVsockDefFree(vsock);
>
> This free is bogus - on success we consume the pointer and on failure
> the caller frees the device.
>
> I'll remove it before pushing.
>
yeah, right. Saw this too and wondered, started looking for it, then got
distracted... Looking again, now I wonder about qemuDomainAttachMemory
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
