On 06/04/2018 09:58 AM, Peter Krempa wrote: > On EOF, the loop can be terminated right away since most of it is > skipped anyways and the handling of the last command is repeated after > the loop. > > Signed-off-by: Peter Krempa <pkre...@redhat.com> > --- > tests/qemumonitortestutils.c | 24 +++++++++++------------- > 1 file changed, 11 insertions(+), 13 deletions(-) > Would this be more readable with virStringSplit[Count] ? Every time I see strchr, that's where I go... What's here is fine, but figured I'd ask anyway. Reviewed-by: John Ferlan <jfer...@redhat.com> John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
- [libvirt] [PATCH 00/10] tests: qemucapabilities: Record and t... Peter Krempa
- [libvirt] [PATCH 01/10] qemu: monitor: Add possibility t... Peter Krempa
- [libvirt] [PATCH 04/10] tests: qemumonitor: Optimize con... Peter Krempa
- [libvirt] [PATCH 02/10] tests: qemucapabilities: Reset c... Peter Krempa
- [libvirt] [PATCH 03/10] tests: qemumonitor: Simplify han... Peter Krempa
- Re: [libvirt] [PATCH 03/10] tests: qemumonitor: Simp... John Ferlan
- Re: [libvirt] [PATCH 03/10] tests: qemumonitor: ... Peter Krempa
- [libvirt] [PATCH 06/10] tests: qemucapsprobemock: Fail i... Peter Krempa
- [libvirt] [PATCH 05/10] tests: qemucapsprobemock: Simpli... Peter Krempa
- [libvirt] [PATCH 07/10] tests: qemucapsprobemock: Prepar... Peter Krempa
- [libvirt] [PATCH 08/10] tests: qemucapabilities: Test co... Peter Krempa