On Sat, Jul 28, 2018 at 11:31:27PM +0530, Sukrit Bhatnagar wrote: > By making use of GNU C's cleanup attribute handled by the > VIR_AUTOFREE macro for declaring scalar variables, majority > of the VIR_FREE calls can be dropped, which in turn leads to > getting rid of most of our cleanup sections. > > Signed-off-by: Sukrit Bhatnagar <skrtbht...@gmail.com> > --- > src/util/virnetdevip.c | 95 > ++++++++++++++++++-------------------------------- > 1 file changed, 33 insertions(+), 62 deletions(-) > > diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c > index fdb0b74..8f1081b 100644 > --- a/src/util/virnetdevip.c > +++ b/src/util/virnetdevip.c > @@ -171,11 +171,11 @@ virNetDevIPAddrAdd(const char *ifname, > virSocketAddr *broadcast = NULL; > int ret = -1; > struct nl_msg *nlmsg = NULL;
As I pointed out earlier, ^this could be converted to VIR_AUTOPTR. Otherwise it's fine. Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
