On Wed, Aug 22, 2018 at 11:44:16AM +0200, Andrea Bolognani wrote: > Other user-defined variables use underscores as > separator instead of dashes; this change will also > help us out later.
There are variables like child-workspace, block-upstream, days-to-keep, etc. in most of the templates under jobs/ which would fancy a similar care since you're striving for consistency in variable naming here. Anyway, I'm quite ambivalent about the patch, I don't mind having it in, but I don't feel like this is the kind of change we want to merge. Having said that though, there already are commits like that, so my argument is invalid. If you show some love to the other variables which suffer from the same "plague" too: Reviewed-by: Erik Skultety <eskul...@redhat.com> -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
