On 08/27/2018 07:23 AM, Wang Huaqiang wrote: > To add CMT/MBM feature and let code be consistent in later patches, > renaming variable name from 'controlBuf' to 'childrenBuf', locates > in functions 'virCapabilitiesFormatCaches' and > 'virCapabilitiesFormatMemoryBandwidth'. > > Signed-off-by: Wang Huaqiang <huaqiang.w...@intel.com> > --- > .gnulib | 1 - Gaah!!! Don't do that! > src/conf/capabilities.c | 28 ++++++++++++++-------------- > 2 files changed, 14 insertions(+), 15 deletions(-) > delete mode 160000 .gnulib > > diff --git a/.gnulib b/.gnulib > deleted file mode 160000 > index 68df637..0000000 > --- a/.gnulib > +++ /dev/null > @@ -1 +0,0 @@ > -Subproject commit 68df637b5f1b5c10370f6981d2a43a5cf74368df Luckily I can delete this hunk out of my .eml file before git am'ing the series. The rest is fine by me, allows childrenBuf to catch up with childBuf variables. At least in this case there's multiple elements within for loops being added as opposed to some other uses where there's just one. Reviewed-by: John Ferlan <jfer...@redhat.com> John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
- Re: [libvirt] [PATCH 04/10] test: add test case for re... John Ferlan
- Re: [libvirt] [PATCH 04/10] test: add test case fo... Wang, Huaqiang
- Re: [libvirt] [PATCH 04/10] test: add test cas... John Ferlan
- Re: [libvirt] [PATCH 04/10] test: add test... Wang, Huaqiang
- [libvirt] [PATCH 02/10] util: add interface retrieving CMT ... Wang Huaqiang
- Re: [libvirt] [PATCH 02/10] util: add interface retrie... John Ferlan
- Re: [libvirt] [PATCH 02/10] util: add interface re... Wang, Huaqiang
- Re: [libvirt] [PATCH 02/10] util: add interfac... John Ferlan
- Re: [libvirt] [PATCH 02/10] util: add inte... Wang, Huaqiang
- [libvirt] [PATCH 01/10] conf: Renamed 'controlBuf' to 'chil... Wang Huaqiang
- Re: [libvirt] [PATCH 01/10] conf: Renamed 'controlBuf'... John Ferlan
- Re: [libvirt] [PATCH 01/10] conf: Renamed 'control... Wang, Huaqiang
- [libvirt] [PATCH 06/10] util: Introduce resctrl monitor for... Wang Huaqiang
- Re: [libvirt] [PATCH 06/10] util: Introduce resctrl mo... John Ferlan
- Re: [libvirt] [PATCH 06/10] util: Introduce resctr... Wang, Huaqiang
- [libvirt] [PATCH 03/10] conf: Add CMT capability to host Wang Huaqiang
- Re: [libvirt] [PATCH 03/10] conf: Add CMT capability t... John Ferlan
- Re: [libvirt] [PATCH 03/10] conf: Add CMT capabili... Wang, Huaqiang
- Re: [libvirt] [PATCH 03/10] conf: Add CMT capa... John Ferlan
- Re: [libvirt] [PATCH 03/10] conf: Add CMT ... Wang, Huaqiang