Pavel, On Tue, Sep 18, 2018 at 2:17 PM, Pavel Hrdina <phrd...@redhat.com> wrote:
> Pavel Hrdina (9): > vircgroup: cleanup controllers not managed by systemd on error > vircgroup: fix bug in virCgroupEnableMissingControllers > vircgroup: rename virCgroupAdd.*Task to virCgroupAdd.*Process > vircgroup: introduce virCgroupTaskFlags > vircgroup: introduce virCgroupAddThread > vircgroupmock: cleanup unused cgroup files > vircgroupmock: rewrite cgroup fopen mocking > vircgrouptest: call virCgroupDetectMounts directly > vircgrouptest: call virCgroupNewSelf instead virCgroupDetectMounts > > src/libvirt-lxc.c | 2 +- > src/libvirt_private.syms | 6 +- > src/lxc/lxc_controller.c | 4 +- > src/qemu/qemu_process.c | 4 +- > src/qemu/qemu_tpm.c | 2 +- > src/util/vircgroup.c | 135 +++++++----- > src/util/vircgroup.h | 5 +- > src/util/vircgrouppriv.h | 4 - > tests/vircgroupdata/all-in-one.cgroups | 7 + > tests/vircgroupdata/all-in-one.mounts | 2 +- > tests/vircgroupdata/all-in-one.parsed | 12 +- > tests/vircgroupdata/all-in-one.self.cgroup | 1 + > tests/vircgroupdata/cgroups1.cgroups | 11 + > tests/vircgroupdata/cgroups1.self.cgroup | 11 + > tests/vircgroupdata/cgroups2.cgroups | 10 + > tests/vircgroupdata/cgroups2.self.cgroup | 10 + > tests/vircgroupdata/cgroups3.cgroups | 12 + > tests/vircgroupdata/cgroups3.self.cgroup | 12 + > tests/vircgroupdata/fedora-18.cgroups | 10 + > tests/vircgroupdata/fedora-18.self.cgroup | 9 + > tests/vircgroupdata/fedora-21.cgroups | 12 + > tests/vircgroupdata/fedora-21.self.cgroup | 10 + > tests/vircgroupdata/kubevirt.cgroups | 10 + > tests/vircgroupdata/kubevirt.self.cgroup | 10 + > tests/vircgroupdata/logind.cgroups | 10 + > tests/vircgroupdata/logind.mounts | 2 + > tests/vircgroupdata/logind.self.cgroup | 1 + > tests/vircgroupdata/ovirt-node-6.6.cgroups | 9 + > .../vircgroupdata/ovirt-node-6.6.self.cgroup | 8 + > tests/vircgroupdata/ovirt-node-7.1.cgroups | 11 + > .../vircgroupdata/ovirt-node-7.1.self.cgroup | 10 + > tests/vircgroupdata/rhel-7.1.cgroups | 11 + > tests/vircgroupdata/rhel-7.1.self.cgroup | 10 + > tests/vircgroupdata/systemd.cgroups | 8 + > tests/vircgroupdata/systemd.mounts | 11 + > tests/vircgroupdata/systemd.self.cgroup | 6 + > tests/vircgroupmock.c | 206 ++---------------- > tests/vircgrouptest.c | 24 +- > 38 files changed, 362 insertions(+), 276 deletions(-) > create mode 100644 tests/vircgroupdata/all-in-one.cgroups > create mode 100644 tests/vircgroupdata/all-in-one.self.cgroup > create mode 100644 tests/vircgroupdata/cgroups1.cgroups > create mode 100644 tests/vircgroupdata/cgroups1.self.cgroup > create mode 100644 tests/vircgroupdata/cgroups2.cgroups > create mode 100644 tests/vircgroupdata/cgroups2.self.cgroup > create mode 100644 tests/vircgroupdata/cgroups3.cgroups > create mode 100644 tests/vircgroupdata/cgroups3.self.cgroup > create mode 100644 tests/vircgroupdata/fedora-18.cgroups > create mode 100644 tests/vircgroupdata/fedora-18.self.cgroup > create mode 100644 tests/vircgroupdata/fedora-21.cgroups > create mode 100644 tests/vircgroupdata/fedora-21.self.cgroup > create mode 100644 tests/vircgroupdata/kubevirt.cgroups > create mode 100644 tests/vircgroupdata/kubevirt.self.cgroup > create mode 100644 tests/vircgroupdata/logind.cgroups > create mode 100644 tests/vircgroupdata/logind.mounts > create mode 100644 tests/vircgroupdata/logind.self.cgroup > create mode 100644 tests/vircgroupdata/ovirt-node-6.6.cgroups > create mode 100644 tests/vircgroupdata/ovirt-node-6.6.self.cgroup > create mode 100644 tests/vircgroupdata/ovirt-node-7.1.cgroups > create mode 100644 tests/vircgroupdata/ovirt-node-7.1.self.cgroup > create mode 100644 tests/vircgroupdata/rhel-7.1.cgroups > create mode 100644 tests/vircgroupdata/rhel-7.1.self.cgroup > create mode 100644 tests/vircgroupdata/systemd.cgroups > create mode 100644 tests/vircgroupdata/systemd.mounts > create mode 100644 tests/vircgroupdata/systemd.self.cgroup > > -- > 2.17.1 > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > I went through your series and the patches are mostly looking there. There are a few comments in the series related to some typos and an actual problem in the last patch. Please, do *not* push the reviewed patches already as I'd give them the chance to be reviewed by someone who's more experienced with this piece of code. Let me know when you submit a v2 and I'll just check the 9th patch. Best Regards, -- Fabiano Fidêncio
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list