On 09/20/2018 08:10 AM, Philipp Hahn wrote: > Hello, > > event-test.py is bad at handling newer livecycle events. > Attached are two patches to improve that. > > Philipp Hahn (2): > event-test.py: Sync list of domain lifecycle events > event-test.py: Future proof lifecycle event handling > > examples/event-test.py | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) >
Philipp, ACK to the first patch, no doubt about that. However, the second one - I'm torn. One one hand it makes the code more future proof, on the other - seeing a traceback (which is easy to spot) might inspire users to post patches (because we are obviously not doing a good job in keeping event-test.py in sync with libvirt). What do you think? Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
