On Thu, Nov 15, 2018 at 12:36 AM Andrea Bolognani <abolo...@redhat.com> wrote:
> On Wed, 2018-11-14 at 15:19 +0800, Han Han wrote: > > When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it > > always returns 0 or no snapshot. Because we never implement funtions > > to list no-metadata snapshot in virDomainSnapshotObjListGetNames(): > > > > if ((data.flags & VIR_DOMAIN_SNAPSHOT_FILTERS_METADATA) == > > VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA) > > return 0; > > > > Add notes for that flag. > > > > Please update the comment and man page of that flag when no-metadata > > snapshot list is implemented in the future. > > I could be missing some information, but from a quick look at the > commit message and the patch it looks to me like you're documenting > a known limitation instead of, you know, addressing it :) > > Bug filed as : https://bugzilla.redhat.com/show_bug.cgi?id=1650419 > If you are able to fix the issue yourself, then please do so; > otherwise, filing a bug seems like it would be a more appropriate > course of action. > > -- > Andrea Bolognani / Red Hat / Virtualization > > -- Best regards, ----------------------------------- Han Han Quality Engineer Redhat. Email: h...@redhat.com Phone: +861065339333
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list