On 10/22/2009 03:38 PM, Daniel P. Berrange wrote:
On Thu, Oct 22, 2009 at 03:33:37PM -0400, Laine Stump wrote:
On 10/22/2009 03:05 PM, Cole Robinson wrote:
Looks like the patch was mangled. Just pasting the patch into your
client probably won't be sufficient. I'd recommend git format-patch and
git send-email, or just attach the patch file.
Actually, I found out earlier today that when a patch is sent as an
attachment, and I reply to that message message using Thunderbird, the
attachment isn't included in the reply (and so obviously isn't sitting
there quoted), making it more difficult to comment.
Either that's a Thunderbird bug, or the attachment isn't text/plain.
The message wsa one that DV sent this morning. I just checked and it is
a text/plain attachment. Thunderbird was happy to *display* the
attachment inline, but didn't want to include it inline in a reply. I
did just figure out a workaround - select the entire displayed message
prior to hitting reply, and it will include (and quote) the attachment
contents in the reply.
Sometimes mailers use silly things like text/x-patch and that confuses
things. Sending them inline is safest if using a decent editor
Thunderbird isn't "decent" in that respect either ;-) I've been unable
to prevent it from mangling stuff I paste into messages (of course, I
haven't tried very hard either).
which
can insert files without line wrapping, or using git-send-email
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
