On Wed, 2019-01-23 at 16:32 -0500, Cole Robinson wrote: > qemu vhost-scsi devices map to XML roughly like: > > <hostdev mode='subsystem' type='scsi_host'> > <source protocol='vhost' wwpn=X/> > </hostdev> > > To support vhost-scsi-pci-{non-}traditional in qemu, we > need to to extend the SCSI Host hostdev XML to handle > model= value. This matches the XML model= format used > for mediated devices. This is just the domain_conf bits > and some XML test cases. > > Use of virtio-X naming here does not match the hostdev > protocol=vhost nor does it match the qemu vhost-X device > naming, however it's more consistent with all other > model= names in this area, and also matches the > inconsistency of <vsock> devices which use model=virtio > but map to vhost-vsock on the qemu commandline > > Reviewed-by: Andrea Bolognani <abolo...@redhat.com> > Signed-off-by: Cole Robinson <crobi...@redhat.com> > --- > docs/formatdomain.html.in | 5 ++- > docs/schemas/domaincommon.rng | 9 +++++ > src/conf/domain_conf.c | 38 ++++++++++++++++--- > src/conf/domain_conf.h | 12 ++++++ > src/libvirt_private.syms | 2 + > .../virtio-non-transitional.x86_64-3.1.0.args | 3 ++ > ...virtio-non-transitional.x86_64-latest.args | 3 ++ > .../virtio-non-transitional.xml | 3 ++ > .../virtio-transitional.x86_64-3.1.0.args | 3 ++ > .../virtio-transitional.x86_64-latest.args | 3 ++ > .../qemuxml2argvdata/virtio-transitional.xml | 3 ++ > .../virtio-non-transitional.xml | 9 +++++ > .../virtio-transitional.xml | 9 +++++ > 13 files changed, 96 insertions(+), 6 deletions(-)
With the usual caveat about formatting model='virtio' by default Reviewed-by: Andrea Bolognani <abolo...@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list