On Mon, 18 Feb 2019, Christian Ehrhardt wrote:
> +        virBufferAddLit(&buf, "  \"/usr/lib{,32,64}/dri/**.so\" mr,\n");
> +        virBufferAddLit(&buf, "  \"/usr/lib/@{multiarch}/dri/**.so\" mr,\n");
> +        virBufferAddLit(&buf, "  \"/usr/lib/fglrx/dri/**.so\" mr,\n");

I'm sorry I think I wasn't clear on how to add in the .so files. I suggest:

  virBufferAddLit(&buf, "  \"/usr/lib{,32,64}/dri/*.so*\" mr,\n");
  virBufferAddLit(&buf, "  \"/usr/lib/@{multiarch}/dri/*.so*\" mr,\n");
  virBufferAddLit(&buf, "  \"/usr/lib/fglrx/dri/*.so*\" mr,\n");

This is slightly futureproofed with the trailing '*'. On my system, the '**'
wasn't needed, but if you observe systems where it is, feel free to keep it.

The other parts of this patch looked fine.

-- 
Jamie Strandboge             | http://www.canonical.com

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to