On Wed, Mar 06, 2019 at 17:54:00 +0100, Andrea Bolognani wrote: > Despite its name, this is really just a general-purpose string > manipulation function, so it should be moved to the virstring > module and renamed accordingly. > > In addition to the obvious s/File/String/, also tweak the name > to make it clear that the presence of the suffix is verified > using case-insensitive comparison.
How about also adding a function comment with it? > > A few trivial whitespace changes are squashed in. > > Signed-off-by: Andrea Bolognani <abolo...@redhat.com> ACK. You could also fix the return value type.
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
