On 3/4/19 10:34 PM, Eric Blake wrote: > Pull out the portion of virDomainSnapshotRefinePrep() that deals > with definition sanity into a separate helper routine that can > be reused with bulk redefine, leaving behind only the code > specific to loop checking and in-place updates that are only > needed in single-definition handling. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > src/conf/snapshot_conf.c | 186 ++++++++++++++++++++------------------- > 1 file changed, 96 insertions(+), 90 deletions(-) > Reviewed-by: John Ferlan <jfer...@redhat.com> John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
- [libvirt] [PATCH v3 02/18] snapshot: Rework virDomainSnapshotS... Eric Blake
- [libvirt] [PATCH v3 08/18] snapshot: Avoid latent use-after-fr... Eric Blake
- [libvirt] [PATCH v3 13/18] snapshot: Add VIR_DOMAIN_SNAPSHOT_C... Eric Blake
- [libvirt] [PATCH v3 16/18] qemu: Factor out qemuDomainSnapshot... Eric Blake
- [libvirt] [PATCH v3 18/18] qemu: Implement bulk snapshot opera... Eric Blake
- [libvirt] [PATCH v3 17/18] qemu: Const-correct snapshot direct... Eric Blake
- [libvirt] [PATCH v3 10/18] snapshot: Split out virDomainSnapsh... Eric Blake
- Re: [libvirt] [PATCH v3 10/18] snapshot: Split out virDom... John Ferlan
- [libvirt] [PATCH v3 01/18] qemu: Refactor snapshot check for _... Eric Blake
- [libvirt] [PATCH v3 03/18] qemu: Use virDomainSnapshotState fo... Eric Blake
- [libvirt] [PATCH v3 11/18] snapshot: Add virDomainSnapshotObjL... Eric Blake
- [libvirt] [PATCH v3 06/18] snapshot: Add virDomainSnapshotObjL... Eric Blake
- [libvirt] [PATCH v3 04/18] snapshot: Give virDomainSnapshotDef... Eric Blake
- [libvirt] [PATCH v3 14/18] virsh: Expose bulk snapshot dumpxml... Eric Blake