On Thu, Mar 07, 2019 at 10:29:14AM +0100, Michal Privoznik wrote:
> Except not really. At least for now.
> 
> In the future, the firmware will be selected automagically.
> Therefore, it makes no sense to require the pathname of a
> specific firmware binary in the domain XML. But since it is not
> implemented do not really allow the path to be NULL. Only move
> code around to prepare it for further expansion.
> 
> Signed-off-by: Michal Privoznik <mpriv...@redhat.com>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
> ---
>  docs/schemas/domaincommon.rng |  4 +++-
>  src/conf/domain_conf.c        | 29 +++++++++++++++++++++++++++--
>  2 files changed, 30 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to