On Fri, Mar 08, 2019 at 04:05:58PM -0700, Jim Fehlig wrote:
> Add support in the domXML<->native config converter for
> max_grant_frames. Include a test for the conversion.
> 
> Signed-off-by: Jim Fehlig <jfeh...@suse.com>
> ---
>  src/xenconfig/xen_xl.c                    | 56 +++++++++++++++++++++++
>  tests/xlconfigdata/test-max-gntframes.cfg | 13 ++++++
>  tests/xlconfigdata/test-max-gntframes.xml | 32 +++++++++++++
>  tests/xlconfigtest.c                      |  4 ++
>  4 files changed, 105 insertions(+)
> 

> diff --git a/tests/xlconfigdata/test-max-gntframes.xml 
> b/tests/xlconfigdata/test-max-gntframes.xml
> new file mode 100644
> index 0000000000..de7c1c09b2
> --- /dev/null
> +++ b/tests/xlconfigdata/test-max-gntframes.xml
> @@ -0,0 +1,32 @@
> +<domain type='xen'>
> +  <name>XenGuest1</name>
> +  <uuid>45b60f51-88a9-47a8-a3b3-5e66d71b2283</uuid>
> +  <memory unit='KiB'>524288</memory>
> +  <currentMemory unit='KiB'>524288</currentMemory>
> +  <vcpu placement='static'>1</vcpu>
> +  <bootloader>/usr/bin/pygrub</bootloader>
> +  <os>
> +    <type arch='x86_64' machine='xenpv'>linux</type>
> +  </os>
> +  <clock offset='utc' adjustment='reset'/>
> +  <on_poweroff>preserve</on_poweroff>
> +  <on_reboot>restart</on_reboot>
> +  <on_crash>preserve</on_crash>
> +  <devices>
> +    <disk type='file' device='disk'>
> +      <driver name='qemu' type='qcow2'/>
> +      <source file='/var/lib/xen/images/debian/disk.qcow2'/>
> +      <target dev='xvda' bus='xen'/>
> +    </disk>
> +    <controller type='xenbus' index='0' maxGrantFrames='64'/>

Same note about <controller> coming first

> +    <interface type='ethernet'>
> +      <mac address='5a:36:0e:be:00:09'/>
> +    </interface>
> +    <console type='pty'>
> +      <target type='xen' port='0'/>
> +    </console>
> +    <input type='mouse' bus='xen'/>
> +    <input type='keyboard' bus='xen'/>
> +    <memballoon model='xen'/>
> +  </devices>
> +</domain>

Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to