On 3/21/19 7:41 PM, John Ferlan wrote:
> 
> 
> On 3/20/19 1:41 AM, Eric Blake wrote:
>> Change the return value of virDomainSnapshotObjLisParse() to return
> 
> *ListParse
> 
>> the number of snapshots imported, and allow a return of 0 (the
>> original proposal of adding a flag to virDomainSnapshotCreateXML
>> required returning an arbitrary non-NULL snapshot, but with a new API
>> that returns a count, we are no longer constrained to a non-empty
>> list).
>>
>> Document which flags are supported (namely, just SECURE) in
>> virDomainSnapshotObjListFormat().
>>
>> Signed-off-by: Eric Blake <ebl...@redhat.com>
>> ---
>>  src/conf/virdomainsnapshotobjlist.c | 19 +++++++++----------
>>  1 file changed, 9 insertions(+), 10 deletions(-)
>>
> 
> Perhaps 2 separate patches since I don't think they're related.

I kept it as one, but retitled the patch and shifted it earlier in the
series before pushing it.

> 
> Reviewed-by: John Ferlan <jfer...@redhat.com>
> 
> John
> 
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to