The commit summary could be more specific, for example: Guest Domains: fix code example
but more importantly, it is missing a Sign-off. See point 6 at https://libvirt.org/hacking.html#patches Contributors to libvirt projects must assert that they are in compliance with the Developer Certificate of Origin 1.1. This is achieved by adding a "Signed-off-by" line containing the contributor's name and e-mail to every commit message. The presence of this line attests that the contributor has read the above lined DCO and agrees with its statements. (You can just provide the sign-off in an on-list reply to this e-mail and I will add it to the commit message before pushing) Jano On Fri, Apr 05, 2019 at 05:58:43PM +0200, Ilias Stamatis wrote:
---
en-US/Guest_Domains.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/en-US/Guest_Domains.xml b/en-US/Guest_Domains.xml
index c15bbb8..2a4ef7c 100644
--- a/en-US/Guest_Domains.xml
+++ b/en-US/Guest_Domains.xml
@@ -88,7 +88,7 @@ dom = virDomainLookupByID(conn, domainID);
<example>
<title>Fetching a domain object from an name</title>
<programlisting>
-int domainName = "someguest";
+char *domainName = "someguest";
virDomainPtr dom;
dom = virDomainLookupByName(conn, domainName);
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
