On Thu, 2019-04-11 at 15:59 +0100, Daniel P. Berrangé wrote: > On Wed, Apr 10, 2019 at 01:03:32PM +0200, Andrea Bolognani wrote: > > On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote: > > [...] > > > ./autogen.sh --prefix=\$(pwd)/install-root && > > > make -j3 && > > > make -j3 install && > > > - make -j3 dist || > > > - ( > > > - echo '=== LOG FILE(S) START ==='; > > > - find -name test-suite.log | xargs cat; > > > - echo '=== LOG FILE(S) END ==='; > > > - exit 1 > > > - ) > > > - " > > > + make -j3 dist" > > > > Woops, you should not be removing that double quote, as the entire > > script is stored inside an environment variable! Please make sure to > > fix that before pushing. > > I'm not sure I understand - I removed a " and I also added a " ?
You're right, your patch will work, I was just confused while looking at the diff. Please just leave the closing double quote on its own line, so that there's no ambiguity over what you're doing. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
