On Mon, May 13, 2019 at 12:23 PM Christian Ehrhardt <christian.ehrha...@canonical.com> wrote: > > On Thu, May 9, 2019 at 7:43 PM Daniel Henrique Barboza > <danielhb...@gmail.com> wrote: > > > > This is a VM with 'osxsave' capability declared, when there is no > > 'osxsave' guest support, using this series on top of current master: > > > > > > $ sudo ./run tools/virsh start ub1810-osxsave > > error: Failed to start domain ub1810-osxsave > > error: internal error: process exited while connecting to monitor: > > 2019-05-09T17:10:41.077568Z qemu-system-x86_64: can't apply global > > Skylake-Client-IBRS-x86_64-cpu.osxsave=off: Property '.osxsave' not found > > > > > > Applying this series makes the VM boot up, as intended. > > > > I believe there is room for discussion whether the VM should boot > > up or fail to boot with a "feature not found" error like the case below, > > in a sense of "you can't disable a feature that does not exist": > > > > <feature policy='disable' name='not_a_cap'/> > > > > $ sudo ./run tools/virsh start ub1810-unknown-cap > > error: Failed to start domain ub1810-unknown-cap > > error: unsupported configuration: unknown CPU feature: not_a_cap > > > > But the alternative presented in this series does the trick and it's > > less annoying for existing VMs. > > > > > > For all the patch series: > > > > > > Reviewed-by: Daniel Henrique Barboza <danielhb...@gmail.com> > > Tested-by: Daniel Henrique Barboza <danielhb...@gmail.com> > > Thank you so much Daniel! > > Anyone else to chime in?
Nothing else came up, I have rebased, rebuilt and retested to be sure and then pushed to master. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
