On Wed, Jul 03, 2019 at 02:37:57PM +0200, Peter Krempa wrote:
We've dropped old xend support over a year ago. At this point we can
also drop support for parsing very old configs.

Signed-off-by: Peter Krempa <pkre...@redhat.com>
---
docs/drvxen.html.in      |  3 +--
src/libxl/libxl_driver.c | 14 +++-----------
2 files changed, 4 insertions(+), 13 deletions(-)

@@ -2702,16 +2701,9 @@ libxlConnectDomainXMLFromNative(virConnectPtr conn,
                               driver->xmlopt)))
            goto cleanup;
    } else if (STREQ(nativeFormat, XEN_CONFIG_FORMAT_SEXPR)) {
-        /* only support latest xend config format */
-        if (!(def = xenParseSxprString(nativeConfig,
-                                       NULL,
-                                       -1,
-                                       cfg->caps,
-                                       driver->xmlopt))) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("parsing sxpr config failed"));
-            goto cleanup;
-        }
+        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
+                       _("conversion from 'xen-sxpr' format is no longer 
supported"));

Maybe use XEN_CONFIG_FORMAT_SEXPR here too?

+        goto cleanup;
    } else {

Reviewed-by: Ján Tomko <jto...@redhat.com>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to