We can ignore flags rather than rejecting them as unknown since a
correct implementation of those flags is a no-op given that bhyve
lacks managed save or snapshots.

Signed-off-by: Eric Blake <ebl...@redhat.com>
---
 src/bhyve/bhyve_driver.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index ffda7853b8..c2378c536f 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -584,7 +584,10 @@ bhyveDomainUndefineFlags(virDomainPtr domain, unsigned int 
flags)
     virDomainObjPtr vm;
     int ret = -1;

-    virCheckFlags(0, -1);
+    /* We have no managed save or snapshots, so we can ignore those flags */
+    virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_SAVE |
+                  VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, NULL);
+
     if (!(vm = bhyveDomObjFromDomain(domain)))
         goto cleanup;

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to