On Tue, 2019-10-08 at 22:48 +0200, Fabiano Fidêncio wrote:
> +- name: '{{ project }}: Verify pip mappings'
> +  fail:
> +    msg: 'No mappings defined for {{ item }}'
> +  with_items:
> +    '{{ packages }}'
> +  when:
> +    - pip_mappings[item] is undefined

Turns out you actually need the

  mappings[item] is undefined

check here O:-) I'll add it back.

> +- name: '{{ project }}: Flatten pip package list'
> +  set_fact:
> +    pip_flattened: '{{ pip_flattened }} + [ "{{ pip_temp[item] }}" ]'
> +  with_items:
> +    '{{ temp }}'

This should be

  with_items:
    '{{ pip_temp }}'

With these two issues addressed,

  Reviewed-by: Andrea Bolognani <abolo...@redhat.com>

I'll push patches 2-11 now.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to