Daniel, On Thu, Jan 2, 2020 at 3:59 PM Daniel P. Berrangé <berra...@redhat.com> wrote: > > In the last days before the xmas break I took some time to > eliminate 14 more gnulib modules, bringing us down to just > 50 left to go. They're getting harder to eliminate as we go > on, but to give some hints, I've annotated every module in > bootstrap.conf with a suggested replacement strategy. > > Daniel P. Berrangé (23): > build: set min version for CLang to 3.4 / XCode CLang to 5.1 > docs: expand macOS platform support coverage > travis: add macOS Xcode 11.3 testing > util: add note about event file descriptors on Windows > src: always pull in glib/gstdio.h header > src: switch to use g_setenv/g_unsetenv
In the patch above I'd also take the opportunity and use TRUE/FALSE instead of 1/0 in g_setenv(). Feel free to ignore as this is just a minor nitpick; > util: add compat wrapper for g_fsync > src: use g_fsync for portability > util: introduce virFileDataSync What would be the impact of using g_fsync() on Linuxes as well? > src: use g_lstat() instead of lstat() > src: switch from fnmatch to g_pattern_match_simple This one worries me a little bit about possible breakages, mainly related to wildcards used in libvirtd.conf. > src: replace clock_gettime()/gettimeofday() with g_get_real_time() > src: replace last_component() with g_path_get_basename() Please, take a look at this patch's reply. > util: replace IS_ABSOLUTE_FILE_NAME with g_path_is_absolute > src: replace mdir_name() with g_path_get_dirname() > src: remove unused imports of dirname.h > src: replace getcwd() with g_get_current_dir() > util: use realpath/g_canonicalize_filename > util: replace gethostname() with g_get_hostname() Please, take a look at this patch's reply. > src: replace WSAStartup with g_networking_init() > src: replace strptime()/timegm()/mktime() with GDateTime APIs set > bootstrap: remove now unused gnulib modules > bootstrap: annotate with info about desired replacement > All the comments are more suggestions than blockers. The questions are not blockers in any way. Knowing that, for the series: Reviewed-by: Fabiano Fidêncio <fiden...@redhat.com> [snip] -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
