On Thu, Jan 09, 2020 at 10:07:34AM +0000, Daniel P. Berrangé wrote:
> On Thu, Jan 09, 2020 at 09:16:34AM +0100, Pavel Hrdina wrote:
> > We use this module but we don't have explicit dependency on it.
> > 
> > Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
> > ---
> >  bootstrap.conf | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> GNULIB says
> 
>   https://www.gnu.org/software/gnulib/manual/html_node/pthread_002eh.html
> 
> Portability problems fixed by Gnulib:
> 
>   This header pollutes the namespace with some broken macro
>   implementations for various functions such as strtok_r and
>   gmtime_r: mingw 3.0. 
> 
> We currently build with mingw32-winpthreads-6.0.0, and AFAICT
> that doesn't have the described problem. So I don't think we
> actually need this pthread_h module from GNULIB at all.

I'll drop this patch as I don't remember why I wrote it in the first
place.

Pavel

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to